Re: [PATCH v3 066/105] drm/vc4: txp: Turn the TXP into a CRTC of its own

Hi Maxime,

Have you considered splitting the series into several parts and focusing on merging one at a time? IIRC this the longest series _ever_ submitted to dri-devel, plus it seems to be growing with each revision.

Due to the sheer volume, it's likely to miss various points - large or small (like below).

On Thu, 28 May 2020 at 08:47, Maxime Ripard maxime@cerno.tech wrote:

+static int vc4_txp_enable_vblank(struct drm_crtc *crtc) +{

•   return 0;
  

+}

+static void vc4_txp_disable_vblank(struct drm_crtc *crtc) {}

Core should handle if these are NULL, so the stubs should not be needed.

HTH Emil