Re: [PATCH 2/4] PCI: add functionality for resizing resources v3

On Thu, May 4, 2017 at 1:15 PM, Andy Shevchenko andy.shevchenko@gmail.com wrote:

On Thu, May 4, 2017 at 12:23 PM, Christian König deathsimple@vodafone.de wrote:

...

Am 26.04.2017 um 19:00 schrieb Andy Shevchenko:

static int ...xxx...(...) { unsigned int i; int ret;

if (res->parent)
        release_resource(res);

dev_info() should be here. I commented on this earlier, just forgot.

res->start = 0;
res->end = 0;
dev_info(&bridge->dev, "BAR %d: released %pR\n", i, res);
return i;

}

struct pci_dev *next = bridge; ... do { bridge = next;

    ret = ...xxx...(...);

    if (ret)

Here, of course,

if (ret < 0)

        goto cleanup;

    next = bridge->bus ? bridge->bus->self : NULL;
} while (next);