27.06.2020 23:43, Laurent Pinchart пишет:
Hi Dmitry,
Thank you for the patch.
On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote:
This patch adds missing BUS fields to the display panel descriptions of the panels which are found on NVIDIA Tegra devices:
- AUO B101AW03
- Chunghwa CLAA070WP03XG
- Chunghwa CLAA101WA01A
- Chunghwa CLAA101WB01
- Innolux N156BGE L21
- Samsung LTN101NT05
Suggested-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Signed-off-by: Dmitry Osipenko digetx@gmail.com
drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 87edd2bdf09a..986df9937650 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { .width = 223, .height = 125, },
- .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
- .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ?
To be honest I don't know whether it make sense or not for LVDS. I saw that other LVDS panels in panel-simple.c use the PIXDATA flag and then looked at what timing diagrams in the datasheets show.
The rest looks good, except the Samsung panel for which I haven't been able to locate a datasheet.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Thanks to you and Sam!