On Tue, Jul 31, 2012 at 09:58:04AM -0400, Alex Deucher wrote:
On Tue, Jul 31, 2012 at 5:16 AM, Luca Tettamanti kronos.it@gmail.com wrote:
On Mon, Jul 30, 2012 at 10:45 PM, Alex Deucher alexdeucher@gmail.com wrote:
Regarding patches 3 and 4, it might be easier to just store a pointer to the relevant encoder when you verify ATIF rather than walking the encoder list every time.
Done.
Makes sense, I was unsure about the lifetime of the encoders, but AFAICS they're destroyed only when the module in unloaded.
They are present for the life of the driver.
I had to move to call to radeon_acpi_init after radeon_modeset_init, otherwise the encoders are not present yet (the tear down code path is correct, acpi first, then modeset). Latest and greatest version is attached; I fixed notifications when using custom command codes (tested by Pali Rohár) and implemented your suggestion.
Luca