On Sun, Sep 09, 2018 at 02:03:57PM +0200, Daniel Vetter wrote:
On Sat, Sep 08, 2018 at 03:58:53PM +0200, Neil Armstrong wrote:
Hi Ayan,
On 10/07/2018 15:18, Ayan Kumar Halder wrote:
In the current series of patches, we are trying to add support for AFBC modifiers in malidp. AFBC modifiers adds some constraints to framebuffer size, alignment, pitch, formats, etc. Here we are trying to add support for one combination of AFBC modifier ie AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | AFBC_FORMAT_MOD_SPARSE | AFBC_FORMAT_MOD_YTR. In future, we intend to add support for more combination of AFBC modifiers. Currently, we are trying to enable a basic support of AFBC in malidp.
Thanks for pushing AFBC support, this will help supporting it on other SoCs implementing support like Amlogic, Rockchip or Samsung.
I have one question, is there a way to generate such AFBC buffers without the Mali GPU ? I mean, is there a way to generate some sample buffers with some of the modifier features to validate it without having the complete Mali GPU -> DRM chain ?
An igt would be perfect. We've done that for i915 compressed buffers. Note that it just needs to be an afbc buffer, not actually compressed. Setting all the bits to indicate "uncompressed" for each block is what we did for the i915 test.
Actually no. The i915 test does try to put some compressed data into the buffer.
I have also a pending patch series [1] that allows us to render to compressed buffers with cairo by compressing the results using the GPU.
[1] https://patchwork.freedesktop.org/series/46876/