Hey Emil,
Emil Velikov wrote:
Hi Tobias
On 12 May 2015 at 21:17, Tobias Jakobi tjakobi@math.uni-bielefeld.de wrote:
Don't assume that a plane supports any kind of pixelformat but do a check first.
v2: Simplify the format check. Signed-off-by: Tobias Jakobi tjakobi@math.uni-bielefeld.de
Nice catch ! I will push the tomorrow, unless we hear any objections against it.
Patch 1/2 looks sane imho, although I'm not sure if some of the teams has some (automated?) testing which depends on the lack of transparency.
I'm not sure what you mean by that ('lack of transparency'). If you create your primary plane with a XRGB-type format then this patch doesn't change anything. If you create it with an ARGB-type format then I can assume that the user wants an alpha-channel (he explicitly asks for it).
With best wishes, Tobias
Curious if pinging people (check git log for a list) at #dri-devel or via email might show such users ?
Cheers, Emil