On Tue, Jul 21, 2015 at 03:27:25PM +0300, Laurent Pinchart wrote:
Hi Thierry,
On Tuesday 21 July 2015 11:05:59 Thierry Reding wrote:
On Mon, Jul 20, 2015 at 07:56:20PM +0300, Laurent Pinchart wrote:
From: Thierry Reding treding@nvidia.com
Allow connector names to be used in the specification of the -s option. This requires storing the string passed on the command-line so that it can later be resolved to a connector ID (after the DRM device has been opened).
Connector names are constructed from the connector type name and connector type ID using the same format as used internally in the Linux kernel.
Signed-off-by: Thierry Reding treding@nvidia.com Signed-off-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
tests/modetest/modetest.c | 94 ++++++++++++++++++++++++++++++++++++------ 1 file changed, 82 insertions(+), 12 deletions(-)
I've carried this patch in my tree for too long and I'm now tired of rebasing it. It's thus time to get it in mainline.
Compared to the original version developed by Thierry, I've
- rebased the patch on top of latest master
- dropped dependencies on other WIP patches in Thierry's tree
- fixed printf alignment
- used asprintf to simplify name string allocation
- constructed the connector name using the same format as the Linux kernel
Heh, I started to get all these patches into shape last week, and this will probably give me more rebase headaches.
It shouldn't hurt too much as rebasing your patch on top of the master branch without any other dependency was pretty easy.
But I guess that's what I deserve for letting things slide...
Should I consider this as an Acked-by ? :-)
I don't think you need it since I authored it, but yeah, if this works, just go ahead and I'll figure out what to do about it when rebasing on top of your version.
Thierry