On Wed, Jan 27, 2021 at 05:49:46PM +0300, Dan Carpenter wrote:
On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote:
On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote:
On Wed, 27 Jan 2021 15:13:05 +0100 Greg KH gregkh@linuxfoundation.org wrote:
On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote:
On Wed, 27 Jan 2021 14:51:55 +0100 Greg KH gregkh@linuxfoundation.org wrote:
On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > From: zhangxuezhi zhangxuezhi1@yulong.com > > For st7789v ic,when we need continuous full screen refresh, it > is best to wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi zhangxuezhi1@yulong.com
Please slow down and wait at least a day between patch submissions, there is no rush here.
And also, ALWAYS run scripts/checkpatch.pl on your submissions, so that you don't have a maintainer asking you about basic problems, like are in this current patch :(
thanks,
greg k-h
hi, This is my first patch contribution to Linux, so some of the rules are not very clear .In addition, I can confirm that before sending patch, I check it with checkPatch.py every time.Thank you very much for your help
Please read Documentation/SubmittingPatches which has a link to the checklist and other documentation you should read.
And I doubt you are running checkpatch on your submission, as there is obvious coding style issues in it. If so, please provide the output as it must be broken :(
thanks,
greg k-h
hi, the patch v11 checkpatch.pl output is below:
carlis@bf-rmsz-10:~/work/linux-kernel/linux$ ./scripts/checkpatch.pl 0001-staging-fbtft-add-tearing-signal-detect.patch total: 0 errors, 0 warnings, 0 checks, 176 lines checked
0001-staging-fbtft-add-tearing-signal-detect.patch has no obvious style problems and is ready for submission.
Wow, my apologies!
Andy and Joe, there's something wrong here that is missing the fact that a line is being indented with spaces and not tabs in the patch at https://lore.kernel.org/r/1611754972-151016-1-git-send-email-zhangxuezhi3@gm...
Any ideas what broke?
/*Tearing Effect Line On*/Comments are the exception to the "no spaces at the start of a line" rule. I was expecting that the kbuild-bot would send a Smatch warning for inconsistent indenting, but comments are not counted there either.
I'm sort of surprised that we don't have checkpatch rule about the missing space characters. It should be: "/* Tearing Effect Line On */".
That was going to be my next question, lots of comments added in this patch don't have spaces...
thanks,
greg k-h