Re: [PATCH RFC 06/24] drm/lima: add lima uapi header

On 05/20/2018 09:22 AM, Qiang Yu wrote:

On Fri, May 18, 2018 at 5:33 PM, Marek Vasut <marex@denx.de mailto:marex@denx.de> wrote:

On 05/18/2018 11:27 AM, Qiang Yu wrote:

Commit message is missing

> Signed-off-by: Qiang Yu <yuq825@gmail.com <mailto:yuq825@gmail.com>>
> ---
>  include/uapi/drm/lima_drm.h | 195 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 195 insertions(+)
>  create mode 100644 include/uapi/drm/lima_drm.h
> 
> diff --git a/include/uapi/drm/lima_drm.h b/include/uapi/drm/lima_drm.h
> new file mode 100644
> index 000000000000..9df95e46fb2c
> --- /dev/null
> +++ b/include/uapi/drm/lima_drm.h

Please convert this to the SPDX license identifiers, that is

// SPDX...

OK.

Thanks

> @@ -0,0 +1,195 @@
> +/*
> + * Copyright (C) 2017-2018 Lima Project
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:

[...]

> +#if defined(__cplusplus)
> +extern "C" {
> +#endif

Is this C++ stuff needed ?

This file is used by both kernel and user space programs, so I added this following other xxx_drm.h files here.

Got it

[...]

> +#define LIMA_SUBMIT_FLAG_EXPLICIT_FENCE (1 << 0)
> +#define LIMA_SUBMIT_FLAG_SYNC_FD_OUT    (1 << 1)

BIT(0) and BIT(1) if applicable

I can use BIT() for kernel only files but not this user/kernel shared one, because I see BIT is defined in the kernel only, user need to define it if this file use it.

OK