On 08/11/2012 03:31 AM, Paul Menzel wrote:
As a side note, could you also mention the patch iteration in the tag, that means [PATCH vN] so that I know what is the latest version. That would be great.
Can you (or anyone else reading this) point me to how to do this with git send-email?
I would submit adding the new quirk flags and the LG quirk as separate patches. If it is not too much work, it would be great if you could split them up.
Does git provide any facility to make this easier? As far as I can tell, the process is to start over with a newly cloned repository, apply the current patch, manually back out the changes that I want to separate, commit, manually redo the separate changes, and commit again. Is that correct?
You even added this one from the following commit.
commit bc42aabc6a01b92b0f961d65671564e0e1cd7592 Author: Adam Jackson <ajax@redhat.com> Date: Wed May 23 16:26:54 2012 -0400 drm/edid/quirks: ViewSonic VA2026wI am going to need that quirk. Great!
It's in Linus's tree.
+DEFINE_MUTEX(edid_quirk_list_mutex);
+/**
- drm_edid_mfg_format - format an "encoded" EDID manufacturer ID for printing
- @mfg_id: the encoded manufacturer ID
- @buf: destination buffer for the formated manufacturer ID (minimum 7 bytes)
format*t*ed
Thanks for catching that. I keep finding little typos like that; very annoying.
- return count;
+}
Add an empty line here before the next comment?
/*** DDC fetch and block validation ***/
I'm pretty sure I can manage that. ;-)
+MODULE_PARM_DESC(edid_quirks, "See Documentation/EDID/edid_quirks.txt");
Not all users have access to the Linux source tree, so maybe a small overview is still needed? Or even an URL?
I can't think of a way to provide anything useful within the scope of a parameter description. Any suggestions?
A URL would be great, but what would it be? (I don't have a personal web site, and that doesn't seem really appropriate anyway.)
Thanks again for that great patch. With the comments addressed above you can add my acknowledgment.
Acked-by: Paul Menzel paulepanter@users.sourceforge.net
Thank you for your feedback.
Are you saying that I should add the acked-by? If so, how? (You can probably tell that I'm really struggling with git.)
I am going to try to test that patch too for a Philips and LG TV [2].
I hope it helps.