+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c @@ -184,12 +184,12 @@ static struct device *get_mfd_cell_dev(const char *device_name, int r)
…
- struct i2s_platform_data *i2s_pdata = NULL;
…
I propose to reconsider this update suggestion.
@@ -231,20 +231,21 @@ static int acp_hw_init(void *handle) adev->acp.acp_cell = kcalloc(ACP_DEVS, sizeof(struct mfd_cell), GFP_KERNEL);
- if (adev->acp.acp_cell == NULL)
return -ENOMEM;
…
I suggest to keep this source code place unchanged (at the moment). https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...
@@ -393,6 +399,13 @@ static int acp_hw_init(void *handle) val &= ~ACP_SOFT_RESET__SoftResetAud_MASK; cgs_write_register(adev->acp.cgs_device, mmACP_SOFT_RESET, val); return 0;
+failure:
- kfree(i2s_pdata);
- kfree(adev->acp.acp_res);
- kfree(adev->acp.acp_cell);
- kfree(adev->acp.acp_genpd);
- return ret;
}
/**
I would prefer separate jump targets for efficient exception handling. Please choose more appropriate labels for this function implementation.
I suggest to replace this second delimiter by a blank line.
Regards, Markus