Re: [Intel-gfx] [PATCH] i915: fix ACPI _DSM warning

On Thu, Aug 01, 2013 at 06:21:28PM +0200, Peter Wu wrote:

Since commit 29a241c (ACPICA: Add argument typechecking for all predefined ACPI names), _DSM parameters are validated which trigger the following warning:

ACPI Warning: \_SB_.PCI0.GFX0._DSM: Argument #4 type mismatch - Found [Integer], ACPI requires [Package] (20130517/nsarguments-95)
ACPI Warning: \_SB_.PCI0.GFX0._DSM: Argument #4 type mismatch - Found [Integer], ACPI requires [Package] (20130517/nsarguments-95)
ACPI Warning: \_SB_.PCI0.P0P2.PEGP._DSM: Argument #4 type mismatch - Found [Integer], ACPI requires [Package] (20130517/nsarguments-95)
ACPI Warning: \_SB_.PCI0.P0P2.PEGP._DSM: Argument #4 type mismatch - Found [Integer], ACPI requires [Package] (20130517/nsarguments-95)

As the Intel _DSM method seems to ignore this parameter, let's comply to the ACPI spec and use a Package instead.

Signed-off-by: Peter Wu lekensteyn@gmail.com

What is this code useful for? It seems unfinished, all it does it printing some information when a mux is available, but besides that there is no interaction with the driver.

Dunno how it all works exactly, but yours is not the only report:

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=32602

Queued for -next, thanks for the patch. -Daniel