Hi Daniel
On Mon, Feb 04, 2019 at 11:31:13AM +0100, Daniel Vetter wrote:
The compiler already clears this for us.
More important, someone might look what this is actually used for, and freak out about the dragon staring back at them.
Signed-off-by: Daniel Vetter daniel.vetter@intel.com Cc: Greg Kroah-Hartman gregkh@linuxfoundation.org Cc: Hans de Goede hdegoede@redhat.com Cc: Daniel Vetter daniel.vetter@ffwll.ch Cc: Nicholas Mc Guire der.herr@hofr.at Cc: Emil Velikov emil.velikov@collabora.com Cc: Fabio Rafael da Rosa fdr@pid42.net
drivers/staging/vboxvideo/vbox_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vboxvideo/vbox_drv.c b/drivers/staging/vboxvideo/vbox_drv.c index b0d73d5fba5d..43c3d0a4fa1a 100644 --- a/drivers/staging/vboxvideo/vbox_drv.c +++ b/drivers/staging/vboxvideo/vbox_drv.c @@ -222,7 +222,6 @@ static void vbox_master_drop(struct drm_device *dev, struct drm_file *file_priv) static struct drm_driver driver = { .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME | DRIVER_ATOMIC,
.dev_priv_size = 0,
.lastclose = drm_fb_helper_lastclose, .master_set = vbox_master_set,
I have stared at the file for a long time and so far no dragon was staring back at me. There was a few "#ifdef" that screamed at me, and a drm_fb_helper_fbdev_setup() that looked suspicious alas no dragon :-(
As for the change above, dragon or no dragon: Reviewed-by: Sam Ravnborg sam@ravnborg.org
Sam