thanks for the review comments everyone! I'm going through them now but realized I should probably point out that I somehow sent this patch series and did not realize I did so in the middle of a rebase, and as such completely forgot the parts here that actually started using these helpers in nouveau. lol....
anyway-will fix when I sent out the respin today
On Fri, 2021-02-05 at 18:45 -0500, Lyude Paul wrote:
This series:
- Cleans up i915's DPCD backlight code a little bit
- Extracts i915's DPCD backlight code into a set of shared DRM helpers
- Starts using those helpers in nouveau to add support to nouveau for
DPCD backlight control
v2 series-wide changes:
- Rebase
v3 series-wide changes:
- Split up the changes to intel's backlight code into separate patches
Cc: Jani Nikula jani.nikula@intel.com Cc: Dave Airlie airlied@gmail.com Cc: greg.depoire@gmail.com
Lyude Paul (10): drm/nouveau/kms/nv40-/backlight: Assign prop type once drm/nouveau/kms: Don't probe eDP connectors more then once drm/i915/dpcd_bl: Remove redundant AUX backlight frequency calculations drm/i915/dpcd_bl: Handle drm_dpcd_read/write() return values correctly drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit drm/i915/dpcd_bl: Cache some backlight capabilities in intel_panel.backlight drm/i915/dpcd_bl: Move VESA backlight enabling code closer together drm/i915/dpcd_bl: Return early in vesa_calc_max_backlight if we can't read PWMGEN_BIT_COUNT drm/i915/dpcd_bl: Print return codes for VESA backlight failures drm/dp: Extract i915's eDP backlight code into DRM helpers
drivers/gpu/drm/drm_dp_helper.c | 332 ++++++++++++++++++ .../drm/i915/display/intel_display_types.h | 2 +- .../drm/i915/display/intel_dp_aux_backlight.c | 329 +++-------------- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +- drivers/gpu/drm/nouveau/nouveau_connector.c | 6 + include/drm/drm_dp_helper.h | 48 +++ 6 files changed, 428 insertions(+), 293 deletions(-)