Re: [PATCH] drm/radeon: Bail earlier when radeon.cik_/si_support=0 is passed

On 2019-09-07 10:32 p.m., Hans de Goede wrote:

Bail from the pci_driver probe function instead of from the drm_driver load function.

This avoid /dev/dri/card0 temporarily getting registered and then unregistered again, sending unwanted add / remove udev events to userspace.

Specifically this avoids triggering the (userspace) bug fixed by this plymouth merge-request: https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/59

Note that despite that being an userspace bug, not sending unnecessary udev events is a good idea in general.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1490490 Signed-off-by: Hans de Goede hdegoede@redhat.com

Reviewed-by: Michel Dänzer mdaenzer@redhat.com

amdgpu should be changed correspondingly as well.