Re: [PATCH 2/8] drm/shmem: switch shmem helper to &drm_gem_object_funcs.mmap

Hi,

...

• /* VM_PFNMAP was set by drm_gem_mmap() */
• vma->vm_flags &= ~VM_PFNMAP;
• vma->vm_flags |= VM_MIXEDMAP;

• vma->vm_flags |= (VM_MIXEDMAP|VM_DONTEXPAND);

I'm finding this a bit hard to follow - but I think here we've lost VM_IO and VM_DONTDUMP which used to be set by drm_gem_mmap().

Yep. Intentional, but I think I better split that off to a separate patch with a commit message explaining things.

Also it looks like nothing is fiddling vma->vm_page_prot anymore.

Oops, that one was not intentional. Will fix.

cheers, Gerd