Hi Jagan,
On 24.06.21 10:30, Krzysztof Kozlowski wrote:
On 24/06/2021 04:48, Fabio Estevam wrote:
Hi Jagan/Laurent,
On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart laurent.pinchart@ideasonboard.com wrote:
Looking at the register set, it seems to match the Exynos 5433, supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage that driver instead of adding a new one for the same IP core ?
Yes. there was an attempt from Michael in this direction: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork....
That's the proper direction (maybe as Marek suggested - sharing common code like for Analogix DP), not duplicating a driver.
Just to make sure that you are aware of the previous patches and discussions here are some additional pointers:
* i.MX8MM glue code from Marek (+ Cc): [1] * DPHY driver from Marek: [2] * General discussion about driver implementation: [3] * Daniel's (+ Cc) suggested direction to move forward: [4]
It looks like you already did a fork of the Exynos driver, so your approach might be generally in line with what Daniel suggested.
Best regards Frieder
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201005134250.5... [2] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201003225020.1... [3] https://patchwork.kernel.org/project/dri-devel/patch/20200911135413.3654800-... [4] https://patchwork.kernel.org/project/dri-devel/patch/20200911135413.3654800-...