Re: [PATCH v4 24/27] drm/vkms: Don't set struct drm_device.irq_enabled

On 06/25, Thomas Zimmermann wrote:

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vkms.

Signed-off-by: Thomas Zimmermann tzimmermann@suse.de Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

I've also checked here, lgtm.

Reviewed-by: Melissa Wen melissa.srw@gmail.com

---

drivers/gpu/drm/vkms/vkms_drv.c | 2 -- 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 027ffe759440..496de38ad983 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -163,8 +163,6 @@ static int vkms_create(struct vkms_config *config) goto out_devres; }

• vkms_device->drm.irq_enabled = true;
• ret = drm_vblank_init(&vkms_device->drm, 1); if (ret) { DRM_ERROR("Failed to vblank\n");

-- 2.32.0