Re: [PATCH 1/6] dt-bindings: display: Document NewVision NV3052C DT node

Hi Paul,

Thank you for the patch.

On Mon, Jul 27, 2020 at 06:46:08PM +0200, Paul Cercueil wrote:

Add documentation for the Device Tree node for LCD panels based on the NewVision NV3052C controller.

Signed-off-by: Paul Cercueil paul@crapouillou.net

.../display/panel/newvision,nv3052c.yaml | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3052c.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3052c.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3052c.yaml new file mode 100644 index 000000000000..751a28800fc2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3052c.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/newvision,nv3052c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: NewVision NV3052C TFT LCD panel driver with SPI control bus

s/driver/driver IC/ (or driver chip, or controller, or any other similar term) to avoid confusion with device drivers.

Do I understand that the NV3052C also supports control through DSI ? Shouldn't this appear in the DT bindings ? Do I assume correctly that the panel will be controlled either through SPI or through DSI, but not through both ?

+maintainers:

• • Paul Cercueil paul@crapouillou.net

+description: |

• This is a driver for 320x240 TFT panels, accepting a variety of input
• streams that get adapted and scaled to the panel. The panel output has
• 960 TFT source driver pins and 240 TFT gate driver pins, VCOM, VCOML and
• VCOMH outputs.
• The panel must obey the rules for a SPI slave device as specified in
• spi/spi-controller.yaml

+allOf:

• • $ref: panel-common.yaml#

+properties:

• compatible:
• items:

•  - enum:
  

•    - leadtek,ltk035c5444t-spi
  

According to its datasheet, that panel is 640x480 :-)

I think you need a bit of documentation to explain that two compatible strings are needed, one matching the panel type, and a second one matching the chip.

•  - const: newvision,nv3052c
  

• reg:
• maxItems: 1
• reset-gpios: true
• port: true

The NV3052C requires multiple power supplies, I think this needs to be taken into account here.

+required:

• • compatible
• • reg

+unevaluatedProperties: false

+examples:

• • |
• #include <dt-bindings/gpio/gpio.h>
• spi {

•  #address-cells = <1>;
  

•  #size-cells = <0>;
  

•  display@0 {
  

•    compatible = "leadtek,ltk035c5444t-spi", "newvision,nv3052c";
  

•    reg = <0>;
  

•    spi-max-frequency = <15000000>;
  

•    spi-3wire;
  

•    reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
  

•    backlight = <&backlight>;
  

•    power-supply = <&vcc>;
  

•    port {
  

•      panel_input: endpoint {
  

•          remote-endpoint = <&panel_output>;
  

•      };
  

•    };
  

•  };
  

• };

+...