On 2020-08-18 20:42, Rob Clark wrote:
On Tue, Aug 18, 2020 at 3:03 AM Sai Prakash Ranjan saiprakash.ranjan@codeaurora.org wrote:
Hi,
On 2020-06-01 16:33, Krishna Manikandan wrote:
Define shutdown callback for display drm driver, so as to disable all the CRTCS when shutdown notification is received by the driver.
This change will turn off the timing engine so that no display transactions are requested while mmu translations are getting disabled during reboot sequence.
Signed-off-by: Krishna Manikandan mkrishn@codeaurora.org
Changes in v2: - Remove NULL check from msm_pdev_shutdown (Stephen Boyd) - Change commit text to reflect when this issue was uncovered (Sai Prakash Ranjan)
drivers/gpu/drm/msm/msm_drv.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index e4b750b..94e3963 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -1322,6 +1322,13 @@ static int msm_pdev_remove(struct platform_device *pdev) return 0; }
+static void msm_pdev_shutdown(struct platform_device *pdev) +{
struct drm_device *drm = platform_get_drvdata(pdev);drm_atomic_helper_shutdown(drm);+}
static const struct of_device_id dt_match[] = { { .compatible = "qcom,mdp4", .data = (void *)KMS_MDP4 }, { .compatible = "qcom,mdss", .data = (void *)KMS_MDP5 }, @@ -1334,6 +1341,7 @@ static int msm_pdev_remove(struct platform_device *pdev) static struct platform_driver msm_platform_driver = { .probe = msm_pdev_probe, .remove = msm_pdev_remove,
.shutdown = msm_pdev_shutdown, .driver = { .name = "msm", .of_match_table = dt_match,Any more comments on this patch?
sorry, I managed to overlook this earlier.. I've pulled it in to msm-next
No problem, thanks Rob.
-Sai