Re: [PATCH V3 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select

On Mon, Jul 26, 2021 at 11:02:49PM +0200, Marek Vasut wrote:

Decoder input LVDS format is a property of the decoder chip or even its strapping. Add DT property data-mapping the same way lvds-panel does, to define the LVDS data mapping.

Signed-off-by: Marek Vasut marex@denx.de Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Rob Herring robh+dt@kernel.org Cc: Sam Ravnborg sam@ravnborg.org Cc: devicetree@vger.kernel.org To: dri-devel@lists.freedesktop.org

---

V2: - Use allOf - Move the data-mapping to endpoint V3: - Rebase on V2 submitted a while ago, reinstate changelog - Drop the allOf and un-rebase on previous pclk patch

---

.../bindings/display/bridge/lvds-codec.yaml | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml index 304a1367faaa7..f795c671c3ce1 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml @@ -60,6 +60,21 @@ properties: For LVDS encoders, port 1 is the LVDS output For LVDS decoders, port 1 is the parallel output

•    properties:
  

•      endpoint:
  

•        $ref: /schemas/media/video-interfaces.yaml#
  

Adding this means the 'port' needs to reference '$defs/port-base' instead of 'properties/port'. Otherwise, it's going to start failing when 'unevaluatedProperties' gets implemented (appears to be soon now).

•        unevaluatedProperties: false
  

•        properties:
  

•          data-mapping:
  

•            enum:
  

•              - jeida-18
  

•              - jeida-24
  

•              - vesa-24
  

•            description: |
  

•              The color signals mapping order. See details in
  

•              Documentation/devicetree/bindings/display/panel/lvds.yaml
  

• required: - port@0 - port@1

@@ -71,6 +86,22 @@ properties:

power-supply: true

+if:

• not:
• properties:

•  compatible:
  

•    contains:
  

•      const: lvds-decoder
  

+then:

• properties:
• ports:

•  properties:
  

•    port@1:
  

•      properties:
  

•        endpoint:
  

•          properties:
  

•            data-mapping: false
  

With this, I kind of think the schema should be split into encoder and decoder schemas. But we can leave that for the next addition...

Rob