Re: [PATCH] drm: serialize access to debugs_nodes.list

On Mon, Oct 31, 2011 at 09:06:57AM +0100, Daniel Vetter wrote:

This is just ugly, you're adding a mutex to every drm_info_node, but only use the one embedded into the minor. On a quick grep we're only ever using the list in there, so I suggest to

• replace minor->debugfs_node.list with minor->debugfs_list and kill ->debugfs_node
• add the mutex as minor->debugfs_lock

That way it's clear what's going on.

Yes, you are right. I don't know what the heck I was thinking.

Also, you've forgotten to add the locking to i915/i915_debugfs.c

Yeah. Will fix it too.

Marcin