Hi,
On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson dianders@chromium.org wrote:
We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings.
Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings.
NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here.
Signed-off-by: Douglas Anderson dianders@chromium.org
Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything. Thanks!
[1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quic...
-Doug