Re: [patch] drm/i915: precedence bug in hsw_compute_wm_results()

On Fri, Aug 09, 2013 at 12:43:02PM +0300, Dan Carpenter wrote:

The '!' operation has higher precedence than the compare so probably this test is never true.

Signed-off-by: Dan Carpenter dan.carpenter@oracle.com

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index a5a9959..0b9d9a7 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -2562,7 +2562,7 @@ static void hsw_compute_wm_results(struct drm_device *dev, * a WM level. */ results->enable_fbc_wm = true; for (level = 1; level <= max_level; level++) {

• if (!lp_results[level - 1].fbc_val > lp_maximums->fbc) {
  

• if (lp_results[level - 1].fbc_val <= lp_maximums->fbc) {
  

I didn't spot that '!' at all. It's a stray and should be just removed. -Chris