On Thu, 16 Jun 2022 at 10:41, Maxime Ripard maxime@cerno.tech wrote:
Hi Dave,
On Tue, Jun 14, 2022 at 04:57:45PM +0100, Dave Stevenson wrote:
On Fri, 10 Jun 2022 at 10:30, Maxime Ripard maxime@cerno.tech wrote:
All the CRTCs, including the TXP, have a debugfs file and name so we can consolidate it into vc4_crtc_data.
Signed-off-by: Maxime Ripard maxime@cerno.tech
Reviewed-by: Dave Stevenson dave.stevenson@raspberrypi.com
I was sort of expecting the vc4_debugfs_add_regset32 call to move to vc4_crtc_init so that it would be a common call for crtcs and txp, but that doesn't appear to happen in this set. The debugfs_name for the txp is therefore actually unused.
As of this patch, you're right
This is later changed by some other patch though: https://lore.kernel.org/all/20220610092924.754942-60-maxime@cerno.tech/
Indeed, and that cleans it all up. Perfect.
Dave