Hi Thomas,
On Tue, Jun 22, 2021 at 04:09:49PM +0200, Thomas Zimmermann wrote:
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in imx.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de
drivers/gpu/drm/imx/dcss/dcss-kms.c | 3 ---
Not sure if it's worth the effort but, since DCSS is a completely self-contained driver, maybe it would be good to split this patch in 2 as well.
Anyway, for DCSS bit:
Acked-by: Laurentiu Palcu laurentiu.palcu@oss.nxp.com
Thanks, laurentiu
drivers/gpu/drm/imx/imx-drm-core.c | 11 ----------- 2 files changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c index 37ae68a7fba5..917834b1c80e 100644 --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c @@ -133,8 +133,6 @@ struct dcss_kms_dev *dcss_kms_attach(struct dcss_dev *dcss) if (ret) goto cleanup_mode_config;
- drm->irq_enabled = true;
- ret = dcss_kms_bridge_connector_init(kms); if (ret) goto cleanup_mode_config;
@@ -178,7 +176,6 @@ void dcss_kms_detach(struct dcss_kms_dev *kms) drm_kms_helper_poll_fini(drm); drm_atomic_helper_shutdown(drm); drm_crtc_vblank_off(&kms->crtc.base);
- drm->irq_enabled = false; drm_mode_config_cleanup(drm); dcss_crtc_deinit(&kms->crtc, drm); drm->dev_private = NULL;
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 76819a8ac37f..9558e9e1b431 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -207,17 +207,6 @@ static int imx_drm_bind(struct device *dev) if (IS_ERR(drm)) return PTR_ERR(drm);
- /*
* enable drm irq mode.* - with irq_enabled = true, we can use the vblank feature.** P.S. note that we wouldn't use drm irq handler but* just specific driver own one instead because* drm framework supports only one irq handler and* drivers can well take care of their interrupts*/- drm->irq_enabled = true;
- /*
- set max width and height as default value(4096x4096).
- this value would be used to check framebuffer size limitation
-- 2.32.0