Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote: Hi Archit,

Thank you for the comments!

[...]

...

• total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH;
• if (total_size > EDID_LENGTH) {

• kfree(block);
  

• block = kmalloc(total_size, GFP_KERNEL);
  

• if (!block)
  

• 	return NULL;
  

• /* Yes, read the entire buffer, and do not skip the first
  

•  * EDID_LENGTH bytes.
  

•  */
  

Is this the reason why you aren't using drm_do_get_edid()?

Yes, for some hw specific reason, it is necessary to read the entire EDID buffer starting from 0, not block by block.

[...]

I fixed all your other suggestions. Thank you!