Re: [PATCH] drm/fourcc: Add Arm 16x16 block modifier

On Fri, Jun 21, 2019 at 11:21:08AM +0100, Raymond Smith wrote:

Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to denote the 16x16 block u-interleaved format used in Arm Utgard and Midgard GPUs.

Signed-off-by: Raymond Smith raymond.smith@arm.com

Reviewed-by: Brian Starkey brian.starkey@arm.com

Thanks for chasing this down!

---

include/uapi/drm/drm_fourcc.h | 10 ++++++++++ 1 file changed, 10 insertions(+)

diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 3feeaa3..8ed7ecf 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -743,6 +743,16 @@ extern "C" { #define AFBC_FORMAT_MOD_BCH (1ULL << 11)

/*

• • Arm 16x16 Block U-Interleaved modifier
• • This is used by Arm Mali Utgard and Midgard GPUs. It divides the image
• • into 16x16 pixel blocks. Blocks are stored linearly in order, but pixels
• • in the block are reordered.
• */

+#define DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED \

• fourcc_mod_code(ARM, ((1ULL << 55) | 1))

+/*

• Allwinner tiled modifier
• This tiling mode is implemented by the VPU found on all Allwinner platforms,

-- 2.7.4