Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()

On 01-09-20, 13:01, Rajendra Nayak wrote:

So FWIU, dpu_unbind() gets called even when dpu_bind() fails for some reason.

Ahh, I see.

I tried to address that earlier [1] which I realized did not land.

I don't think that patch was required, as you can call dev_pm_opp_put_clkname() multiple times and it will return without any errors/crash.

But with these changes it will be even more broken unless we identify if we failed dpu_bind() before adding the OPP table, while adding it, or all went well with opps and handle things accordingly in dpu_unbind.

Maybe not as dev_pm_opp_of_remove_table() can be called multiple times as well without any errors or crash.

[1] https://lore.kernel.org/patchwork/patch/1275632/