Hi Dan Carpenter.
Same patch[1] was posted so I will pick it up.
[1] https://www.spinics.net/lists/arm-kernel/msg967488.html
Thanks, Inki Dae
22. 4. 8. 19:21에 Dan Carpenter 이(가) 쓴 글:
The of_drm_find_bridge() does not return error pointers, it returns NULL on error.
Fixes: dd8b6803bc49 ("exynos: drm: dsi: Attach in_bridge in MIC driver") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
-EPROBE_DEFER is the correct return, right?
drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index 9e06f8e2a863..07e04ceb2476 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c @@ -434,9 +434,9 @@ static int exynos_mic_probe(struct platform_device *pdev)
remote = of_graph_get_remote_node(dev->of_node, 1, 0); mic->next_bridge = of_drm_find_bridge(remote);
- if (IS_ERR(mic->next_bridge)) {
- if (!mic->next_bridge) { DRM_DEV_ERROR(dev, "mic: Failed to find next bridge\n");
ret = PTR_ERR(mic->next_bridge);
goto err; }ret = -EPROBE_DEFER;