Re: [PATCH v4 3/3] drm/loongson: Add interrupt driver for LS7A

Hi lichenyang,

On Fri, Jul 30, 2021 at 05:41:48PM +0800, lichenyang wrote:

Add LS7A DC vsync interrupt enable and close function, and register irq_handler function interface. Add vbrank event processing flow.

s/vbrank/vblank/

v4:

• Replace drm_irq_install with devm_request_irq.
• Delete the irq_ hooks in drm_driver.

v3:

• Improve code readability.
• Use the to_pci_dev function to get pci_dev.

v2:

• Added error handling in the loongson_drm_load function.

Signed-off-by: lichenyang lichenyang@loongson.cn

Patch looks good, Acked-by: Sam Ravnborg sam@ravnborg.org

But then I am not to fluent in the vblank stuff, so I hope someone else takes a look too.

Sam