Re: linux-next: Tree for May 6 (nouveau)

When CONFIG_ACPI_BUTTON=m:

drivers/built-in.o: In function `nouveau_connector_detect': nouveau_connector.c:(.text+0x1d81cf): undefined reference to `acpi_lid_open'

#ifdef CONFIG_ACPI if (!nouveau_ignorelid && !acpi_lid_open()) status = connector_status_unknown; #endif

Do you want that to be #ifdef CONFIG_ACPI_BUTTON ? That will still only be built when CONFIG_ACPI_BUTTON=y (not =m).

intel_lvds.c seems to handle this issue without #ifdefs by including acpi/button.h

cheers, Len Brown, Intel Open Source Technology Center