On 23 May 2016 at 13:35, Rob Herring robh@kernel.org wrote:
On Mon, May 23, 2016 at 4:33 AM, Emil Velikov emil.l.velikov@gmail.com wrote:
On 22 May 2016 at 10:05, Geert Uytterhoeven geert@linux-m68k.org wrote:
Submitters of device tree binding documentation may forget to CC the subsystem maintainer if this is missing.
Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org Cc: David Airlie airlied@linux.ie Cc: dri-devel@lists.freedesktop.org
Please apply this patch directly if you want to be involved in device tree binding documentation for your subsystem.
MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS index c79b99dd3a0bf22d..75138c09dd603093 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3868,6 +3868,9 @@ T: git git://people.freedesktop.org/~airlied/linux S: Maintained F: drivers/gpu/drm/ F: drivers/gpu/vga/ +F: Documentation/devicetree/bindings/display/
Contains a mixed bag of fb (drivers/video) and drm ones. Perhaps one could/should move the former to a fb/legacy/other subfolder ?
Yes, there are some poorly designed bindings that reflect the subsystem needs rather than the h/w. They were separate, I moved them all together to hopefully discourage further separate bindings.
I'm slightly concerned that someone will pick one of these and consider it good, basing their design on it. That's why I was thinking that moving them to a subfolder (called nasty/bad-design/legacy and/or alike) might be a good idea.
+F: Documentation/devicetree/bindings/gpu/
nvidia,gk20a.txt samsung-g2d.txt samsung-rotator.txt
These three should be listed alongside the respective drivers and/or moved to display/{tegra,exynos} ?
Possibly, but these bindings pretty much stand on their own.
Having a gpu only in different places does feel odd - nvidia,gk20a (in gpu) vs etnaviv (in display). If we consider 'rotator' a GPU perhaps so are exynos' mixer, mic...
Not saying that one has to do one or the other... just that it's not that bad of an idea ;-)
Emil