Hi Sumit.
On Wed, Aug 26, 2020 at 09:33:07PM +0530, Sumit Semwal wrote:
Novatek nt36672a is a display driver IC that can drive DSI panel. It is also present in the Tianma video mode panel, which is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones.
This patch adds the display driver for the IC, with support added for this tianma fhd video mode panel.
Signed-off-by: Sumit Semwal sumit.semwal@linaro.org Reviewed-by: Rob Herring robh@kernel.org
Looks fine, just a few comments in the following. Should be easy to fix.
Sam
v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. v5: renamed to novatek,nt36672a, since the binding is for the IC and not the panel.
.../display/panel/novatek,nt36672a.yaml | 81 +++++++++++++++++++ 1 file changed, 81 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml new file mode 100644 index 000000000000..7f8d1097bee0 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml @@ -0,0 +1,81 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/novatek,nt36672a.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Novatek NT36672A based DSI display Panels
+maintainers:
- Sumit Semwal sumit.semwal@linaro.org
+description: |
- The nt36672a IC from Novatek is a generic DSI Panel IC used to drive dsi
- panels.
- Right now, support is added only for a Tianma FHD+ LCD display panel with a
- resolution of 1080x2246. It is a video mode DSI panel.
+allOf:
- $ref: panel-common.yaml#
+properties:
- compatible:
- items:
- const: tianma,fhd-video- const: novatek,nt36672a
Similar bindings uses following pattaern: properties: compatible: items: - enum: - dlink,dir-685-panel - const: ilitek,ili9322
See ow an "- enum" is used for the part where we expect to add more compatible in the future. And const for the fixed part. Notice the indent - this is right.
- description: This indicates the panel manufacturer of the panel that is
in turn using the NT36672A panel driver. This compatible stringdetermines how the NT36672A panel driver is configured for the indicatedpanel. The novatek,nt36672a compatible shall always be provided as a fallback.- reg: true
- reset-gpios:
- description: phandle of gpio for reset line - This should be 8mA, gpio
can be configured using mux, pinctrl, pinctrl-names (active high)
add empty line, or rely on the generic description in panel-common.
- vddio-supply:
- description: phandle of the regulator that provides the supply voltage
Power IC supply
add empty line
- vddpos-supply:
- description: phandle of the positive boost supply regulator
add empty line
- vddneg-supply:
- description: phandle of the negative boost supply regulator
add empty line
- port: true
Maybe group all the ": true" properties.
+required:
- compatible
- reg
- vddi0-supply
- vddpos-supply
- vddneg-supply
- reset-gpios
- port
+unevaluatedProperties: false
+examples:
- |+
- #include <dt-bindings/gpio/gpio.h>
empty line
- dsi0 {
My personal preference is indent examples with 4 spaces - it increased readability.
#address-cells = <1>;#size-cells = <0>;panel@0 {compatible = "tianma,fhd-video", "novatek,nt36672a";reg = <0>;vddi0-supply = <&vreg_l14a_1p88>;vddpos-supply = <&lab>;vddneg-supply = <&ibb>;reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;#address-cells = <1>;#size-cells = <0>;port {tianma_nt36672a_in_0: endpoint {remote-endpoint = <&dsi0_out>;};};};- };
+...
2.28.0