Hi James,
On 3/6/20 4:14 AM, james qian wang (Arm Technology China) wrote:
On Fri, Mar 06, 2020 at 02:42:55AM +0800, Liviu Dudau wrote:
On Wed, Mar 04, 2020 at 02:54:12PM +0000, Vincenzo Frascino wrote:
komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when CONFIG_PM is enabled. Having it disabled triggers the following warning at compile time:
linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12: warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function] static int komeda_rt_pm_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~ linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12: warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function] static int komeda_rt_pm_suspend(struct device *dev)
Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on CONFIG_PM to address the issue.
Cc: "James (Qian) Wang" james.qian.wang@arm.com Cc: Liviu Dudau liviu.dudau@arm.com Cc: Mihail Atanassov mihail.atanassov@arm.com Cc: Brian Starkey brian.starkey@arm.com Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch Signed-off-by: Vincenzo Frascino vincenzo.frascino@arm.com
Hi Vincenzo:
Thanks for the patch.
and Vincenzo & Liviu, sorry
Since there is a patch for this problem already: https://patchwork.freedesktop.org/series/71721/
And I have pushed that old fix to drm-misc-fixes just before I saw this mail. sorry.
No issue, as far as it is fixed :) It is annoying stepping on it during randconfig :)
Thanks for letting me know!
[...]