Re: [PATCH 1/2] drm/panel: Add DT bindings for Sony ACX424AKP

On Mon, Sep 02, 2019 at 11:06:32AM +0200, Linus Walleij wrote:

This adds device tree bindings for the Sony ACX424AKP panel. Let's use YAML.

Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij linus.walleij@linaro.org

---

.../display/panel/sony,acx424akp.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml b/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml new file mode 100644 index 000000000000..29f41fee1b69 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Sony ACX424AKP 4" 480x864 AMOLED panel

+maintainers:

• • Linus Walleij linus.walleij@linaro.org

+allOf:

• • $ref: panel-common.yaml#

+properties:

• compatible:
• const: sony,acx424akp
• reg: true
• port: true
• reset-gpios: true
• vddi-supply:

• description: regulator that supplies the vddi voltage
  

• dsi-command-mode:

• type: boolean
  

• description:
  

•   If this is specified, the panel will be used in command
  

•   mode instead of video mode.
  

I'm not sure there's concensus on this one yet. I think so far the driver decides which mode to use the panel in. Technically this falls into the category of configuration, so it doesn't really belong in the DT.

I vaguely recall from discussions I've had on this subject that there's usually no reason to do video mode if you can do command mode because command mode is more power efficient. This was a long time ago, so I may be misremembering. Perhaps you have different information on this?

Thierry

+required:

• • compatible
• • reg
• • port
• • reset-gpios
• • power-supply

+additionalProperties: false

+examples:

• • |
• panel@0 {

•    compatible = "sony,acx424akp";
  

•    reg = <0>;
  

•    vddi-supply = <&foo>;
  

•    reset-gpios = <&foo_gpio 0 GPIO_ACTIVE_LOW>;
  

•    port {
  

•        panel_in: endpoint {
  

•            remote-endpoint = <&dsi_out>;
  

•        };
  

•    };
  

• };

+... \ No newline at end of file -- 2.21.0