On Tue, Jun 07, 2022 at 09:09:25PM +0200, Stephen Kitt wrote:
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes.
Signed-off-by: Stephen Kitt steve@sk2.org Cc: Lee Jones lee.jones@linaro.org Cc: Daniel Thompson daniel.thompson@linaro.org Cc: Jingoo Han jingoohan1@gmail.com Cc: Helge Deller deller@gmx.de Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org
Reviewed-by: Daniel Thompson daniel.thompson@linaro.org
... and, wowzer, the code before your change wasn't much fun to read!
static int tosa_bl_update_status(struct backlight_device *dev) {
- struct backlight_properties *props = &dev->props; struct tosa_bl_data *data = bl_get_data(dev);
- int power = max(props->power, props->fb_blank);
- int brightness = props->brightness;
- if (power)
brightness = 0;
int brightness = backlight_get_brightness(dev);
tosa_bl_set_backlight(data, brightness);
Daniel.