20 Jun
2018
20 Jun
'18
11:03 a.m.
On 2018-06-20 11:17, Vinod wrote:
On 19-06-18, 16:43, Kiran Gunda wrote:
struct wled { const char *name; struct device *dev; struct regmap *regmap;
- struct mutex lock; /* Lock to avoid race from ISR */
the comment is wrong as you avoid race with thread handler and not the main ISR. The ISR runs in atomic context so you cant use a mutex but you may do so with a thread handler
Will fix the comment in the next series.
+#define WLED_SHORT_DLY_MS 20 +#define WLED_SHORT_CNT_MAX 5 +#define WLED_SHORT_RESET_CNT_DLY_US USEC_PER_SEC
an empty line after defines would be better
Will add it in the next series.
+static int wled_configure_short_irq(struct wled *wled,
struct platform_device *pdev)+{
- int rc = 0, short_irq;
superfluous initialization of rc
Will remove the initialization in next series.