On Wed, 21 Sep 2011 22:50:57 -0000, Michael Witten wrote:
Whilst working on my failing Radeon GPU:
Subject: Re: Curious experiences with a Radeon on the fritz Date: Wed, 21 Sep 2011 18:52:19 -0000 Message-ID: c0efd8527ff34853a23f1d706be29c67-mfwitten@gmail.com http://lists.freedesktop.org/archives/dri-devel/2011-September/014506.html
I made the following trivial improvements to the DRM/Radeon code along the way ([6] fixes a bug):
[1] DRM: comment: drm_crtc{=>_helper}_set_mode [2] DRM: comment: halve -> half [3] DRM: cleanup: Remove unused `gamma_size' [4] DRM: comment: gdm_proc_lists -> drm_proc_lists [5] DRM: cleanup: `size == 0' is never true [6] DRM: bug: RADEON_DEBUGFS_MAX_{NUM_FILES => COMPONENTS} [7] DRM: cleanup: Remove unsused `tmp'
Here is the overall difference:
drivers/gpu/drm/drm_crtc_helper.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 3 --- drivers/gpu/drm/drm_irq.c | 4 ++-- drivers/gpu/drm/drm_proc.c | 2 +- drivers/gpu/drm/radeon/radeon.h | 2 +- drivers/gpu/drm/radeon/radeon_bios.c | 2 +- drivers/gpu/drm/radeon/radeon_combios.c | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 13 ++++++++----- 8 files changed, 15 insertions(+), 15 deletions(-)
When you get the chance, David, please apply all but [4] and [7].
* Patch [4] is not really helpful, because it poorly changes a comment in what is deprecated, probably erroneous code anyway.
* [7] was a mistake on my part.