Re: [PATCH v10 1/3] phy: qcom-edp: add regulator_set_load to edp phy

Quoting Kuogee Hsieh (2022-05-20 13:40:55)

This patch add regulator_set_load() before enable regulator at eDP phy driver.

Signed-off-by: Kuogee Hsieh quic_khsieh@quicinc.com

drivers/phy/qualcomm/phy-qcom-edp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index cacd32f..955466d 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -639,6 +639,18 @@ static int qcom_edp_phy_probe(struct platform_device *pdev) if (ret) return ret;

•   ret = regulator_set_load(edp->supplies[0].consumer, 21800); /* 1.2 V vdda-phy */
  

•   if (ret) {
  

•           dev_err(dev, "failed to set load\n");
  

Which supply failed to set load?

•           return ret;
  

•   }
  

•   ret = regulator_set_load(edp->supplies[1].consumer, 36000); /* 0.9 V vdda-pll */
  

•   if (ret) {
  

•           dev_err(dev, "failed to set load\n");
  

This printk is the same as above. I hope this print never happens or it will not be useful enough to narrow down the issue.

•           return ret;
  

•   }