Re: [PATCH 4/5] drm/selftests: Rename the Kconfig option to CONFIG_DRM_DEBUG_SELFTEST

On Thu, May 03, 2018 at 01:22:16PM +0200, Maarten Lankhorst wrote:

We want to add more DRM selftests, and there's not much point in having a Kconfig option for every single one of them, so make a generic one.

Signed-off-by: Maarten Lankhorst maarten.lankhorst@linux.intel.com

Seems like a reasonable idea.

Reviewed-by: Ville Syrjälä ville.syrjala@linux.intel.com

---

drivers/gpu/drm/Kconfig | 8 ++++---- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/selftests/Makefile | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 757825ac60df..d684855b95c2 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -49,16 +49,16 @@ config DRM_DEBUG_MM

 If in doubt, say "N".

-config DRM_DEBUG_MM_SELFTEST

• tristate "kselftests for DRM range manager (struct drm_mm)"

+config DRM_DEBUG_SELFTEST

• tristate "kselftests for DRM" depends on DRM depends on DEBUG_KERNEL select PRIME_NUMBERS select DRM_LIB_RANDOM default n help

•  This option provides a kernel module that can be used to test
  

•  the DRM range manager (drm_mm) and its API. This option is not
  

•  This option provides kernel modules that can be used to run
  

•  various selftests on parts of the DRM api. This option is not
  

  useful for distributions or general kernels, but only for kernel developers working on DRM and associated drivers.

diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 9d66657ea117..4becc245e359 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -43,7 +43,7 @@ drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o drm_kms_helper-$(CONFIG_DRM_DP_AUX_CHARDEV) += drm_dp_aux_dev.o

obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o -obj-$(CONFIG_DRM_DEBUG_MM_SELFTEST) += selftests/ +obj-$(CONFIG_DRM_DEBUG_SELFTEST) += selftests/

obj-$(CONFIG_DRM) += drm.o obj-$(CONFIG_DRM_MIPI_DSI) += drm_mipi_dsi.o diff --git a/drivers/gpu/drm/selftests/Makefile b/drivers/gpu/drm/selftests/Makefile index 4aebfc7f27d4..f7dd66e859a9 100644 --- a/drivers/gpu/drm/selftests/Makefile +++ b/drivers/gpu/drm/selftests/Makefile @@ -1 +1 @@ -obj-$(CONFIG_DRM_DEBUG_MM_SELFTEST) += test-drm_mm.o

+obj-$(CONFIG_DRM_DEBUG_SELFTEST) += test-drm_mm.o

2.17.0