Re: Questions about KMS flip

On Thu, Nov 04, 2021 at 12:44:34PM -0400, Harry Wentland wrote:

+Nick

It looks to be the old drm_plane_state->fb holds that reference. See dm_plane_helper_cleanup_fb() in amdgpu_dm.c.

BTW looks like you have a possible leak during fb init; amdgpu_display_framebuffer_init() grabs the refs to the BOs, but drm_framebuffer_init() might still fail (at least theoretically) which will then leak those BO refs.

Harry

On 2021-11-04 08:51, Christian König wrote:

...

Hi guys,

adding the usual suspects which might know that of hand: When we do a KMS page flip, who keeps the reference to the BO while it is scanned out?

We are running into warning backtraces from TTM which look more than odd.

Thanks, Christian.