Hi Dmitry,
On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti quic_sbillaka@quicinc.com wrote:
The panel-edp driver modes needs to be validated differently from DP because the link capabilities are not available for EDP by that time.
Signed-off-by: Sankeerth Billakanti quic_sbillaka@quicinc.com
This should not be necessary after https://patchwork.freedesktop.org/patch/479261/?series=101682&rev=1. Could you please check?
The check for DP_MAX_PIXEL_CLK_KHZ is not necessary anymore but we need to return early for eDP because unlike DP, eDP context will not have the information about the number of lanes and link clock.
So, I will modify the patch to return after the DP_MAX_PIXEL_CLK_KHZ check if is_eDP is set.
drivers/gpu/drm/msm/dp/dp_display.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 8bafdd0..f9c7d9a 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1003,6 +1003,12 @@ enum drm_mode_status
dp_bridge_mode_valid(struct drm_bridge *bridge,
return -EINVAL; }
if (dp->connector_type == DRM_MODE_CONNECTOR_eDP) {if (mode_pclk_khz > DP_MAX_PIXEL_CLK_KHZ)return MODE_CLOCK_HIGH;return MODE_OK;}if ((dp->max_pclk_khz <= 0) || (dp->max_pclk_khz > DP_MAX_PIXEL_CLK_KHZ) || (mode->clock > dp->max_pclk_khz))-- 2.7.4
-- With best wishes Dmitry