Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

On Thu, 04 Nov 2021, Javier Martinez Canillas javierm@redhat.com wrote:

+/**

• • drm_drv_enabled - Checks if a DRM driver can be enabled
• • @driver: DRM driver to check
• • Checks whether a DRM driver can be enabled or not. This may be the case
• • if the "nomodeset" kernel command line parameter is used.
• • Return: 0 on success or a negative error code on failure.
• */

+int drm_drv_enabled(const struct drm_driver *driver) +{

• if (vgacon_text_force()) {

• DRM_INFO("%s driver is disabled\n", driver->name);
  

• return -ENODEV;
  

• }
• return 0;

+} +EXPORT_SYMBOL(drm_drv_enabled);

The name implies a bool return, but it's not.

if (drm_drv_enabled(...)) { /* surprise, it's disabled! */ }

BR, Jani.