Re: [PATCH] drm/msm/mdp5: Eliminate useless code

On 19/04/2022 09:16, Haowen Bai wrote:

Since mdp5_state is initialized twice at the same time, so we make code simple and easy to understand by delete one.

Signed-off-by: Haowen Bai baihaowen@meizu.com

Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

---

drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 2 -- 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c index 428f88b786f9..406c34e9f3f8 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c @@ -386,8 +386,6 @@ static int mdp5_plane_atomic_async_check(struct drm_plane *plane, if (!crtc_state->active) return -EINVAL;

• mdp5_state = to_mdp5_plane_state(new_plane_state);
• /* don't use fast path if we don't have a hwpipe allocated yet */ if (!mdp5_state->hwpipe) return -EINVAL;