On 06/15/2018 10:58 PM, Leonard Crestez wrote:
On Fri, 2018-06-15 at 16:47 -0300, Fabio Estevam wrote:
On Fri, Jun 15, 2018 at 4:43 PM, Leonard Crestez leonard.crestez@nxp.com wrote:
The FBDEV driver uses the same name and both can't be registered at the same time. Fix this by renaming the drm driver to mxsfb-drm
Signed-off-by: Leonard Crestez leonard.crestez@nxp.com
Stefan sent the same patch a few days ago: http://www.spinics.net/lists/dri-devel/msg179489.html
In that thread there is a proposal for removing the old fbdev/mxsfb driver entirely.
That would break old DTBs, isn't this generally considered bad? Also, are we sure the removal of fbdev/mxsfb wouldn't lose any features?
What my series does is make both drivers work with the same kernel image and turns the choice into a board-level dtb decision. Supporting everything at once seems desirable to me and it allows for a very smooth upgrade path.
Having two drivers in the kernel with different set of bugs is always bad.
The old driver could be removed later, after all users are converted.
Both drivers were in for long enough already. And let's be realistic, how many MX23/MX28 users of old DTs with new kernels are there who cannot update the DT as well ?
IMO keeping the old FBDEV driver in is just an excuse to postpone the long overdue DT update and I dislike that. Update any remaining DTs and nuke the FBDEV driver already.