On Tue, Jun 07, 2016 at 07:54:35PM +0300, Tomi Valkeinen wrote:
On 07/06/16 15:09, Jyri Sarha wrote:
Add drm_crtc_enable_color_mgmt(), remove drm_helper_crtc_enable_color_mgmt() and update drm/i915-driver (the only user of the old function).
The new function is more flexible. It allows driver to enable only the features it has without forcing to enable all three color management properties: degamma lut, csc matrix (ctm), and gamma lut.
Suggested-by: Daniel Vetter daniel@ffwll.ch Signed-off-by: Jyri Sarha jsarha@ti.com
drivers/gpu/drm/drm_crtc.c | 45 ++++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_crtc_helper.c | 33 ---------------------------- drivers/gpu/drm/i915/intel_color.c | 3 ++- include/drm/drm_crtc.h | 5 ++++- include/drm/drm_crtc_helper.h | 3 --- 5 files changed, 51 insertions(+), 38 deletions(-)
Looks good to me. I can queue this up with the omapdrm patches in this series, if no one complains.
btw would be good if you send a pull for omapdrm in 1-2 weeks latest once this is merged, to avoid unecessary conflicts and other hilarity. -Daniel