Hi Mikko,
On 30 May 2015 at 16:38, Mikko Rapeli mikko.rapeli@iki.fi wrote:
Fixes compiler error since list_head is not exported to userspace headers.
Signed-off-by: Mikko Rapeli mikko.rapeli@iki.fi
include/uapi/drm/via_drm.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/include/uapi/drm/via_drm.h b/include/uapi/drm/via_drm.h index 791531e..34ce658 100644 --- a/include/uapi/drm/via_drm.h +++ b/include/uapi/drm/via_drm.h @@ -272,8 +272,10 @@ typedef struct drm_via_dmablit { drm_via_blitsync_t sync; } drm_via_dmablit_t;
+#ifdef __KERNEL__ struct via_file_private { struct list_head obj_list; }; +#endif
We might want to follow the example of other drivers (i915) and move it to drivers/gpu/drm/via_drv.h, There are two users of this struct (via_drv.c and via_mm.c), and each one explicitly includes the header. How does that sound ?
Same suggestion goes for the equivalent sis patch.
Cheers Emil