Re: [PATCH -next 1/2] drm: Remove redundant NULL check

On Thu, Jul 23, 2020 at 11:27:42AM +0800, Li Heng wrote:

Fix below warnings reported by coccicheck: ./drivers/gpu/drm/drm_drv.c:819:2-7: WARNING: NULL check before some freeing functions is not needed.

Fixes: 5dad34f3c444 ("drm: Cleanups after drmm_add_final_kfree rollout") Signed-off-by: Li Heng liheng40@huawei.com

Queued up, should make it into 5.9 merge window, thanks for your patch. -Daniel

---

drivers/gpu/drm/drm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index bc38322..13068fd 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -815,8 +815,7 @@ static void drm_dev_release(struct kref *ref)

drm_managed_release(dev);

• if (dev->managed.final_kfree)

• kfree(dev->managed.final_kfree);
  

• kfree(dev->managed.final_kfree);

}

/**

2.7.4