7 Feb
2017
7 Feb
'17
2:58 p.m.
Hi Jani,
On 07-02-2017 13:35, Jani Nikula wrote:
On Tue, 07 Feb 2017, Jose Abreu Jose.Abreu@synopsys.com wrote:
+bool drm_scdc_check_scrambling_status(struct i2c_adapter *adapter) +{
- u8 status;
- int ret;
- ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status);
- if (ret < 0) {
DRM_ERROR("Failed to read scrambling status, error %d\n", ret);return false;- }
- return status & SCDC_SCRAMBLING_STATUS;
"return (status & SCDC_SCRAMBLING_STATUS) > 0;" ?
What's the point in that?
BR, Jani.
Sorry, I didn't see the SCDC_SCRAMBLING_STATUS is BIT(0). Anyway, my intention was to return either 1 or 0 or else the value of the "and" would be returned. I think in x86 the bool is char, what could happen if SCDC_SCRAMBLING_STATUS was BIT(>7)? Does the cast work as expected?
Best regards, Jose Miguel Abreu